Redocument with CRAN Roxygen2 #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To avoid large diffs +
Notably, roxygen2 has a new way of ordering things and asks to add
@exportto S3 methodsIt seems that roxygen2 7.3.1 is slower for large packages. r-lib/roxygen2#1593. Hopefully it is fixed soon.
If performance is too much of a burden, I'd recommend accepting only 8813d29 since it will be valid anyway and will reduce noise if we have roxygen2 7.3.1 installed locally.
Checklist
testthatunit tests totests/testthatfor any new functionality.