Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed varint handling on btc tx parser and rsk trie parser #130

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

amendelzon
Copy link
Collaborator

@amendelzon amendelzon commented Feb 8, 2023

  • Handling partial varint parsing in BTC tx parsing
  • Fixing an issue when accumulating a varint raw data both in BTC tx parsing and RSK trie parsing
  • Added both BTC tx and trie unit test cases
  • Added an authorized signing test case to the signer tests
  • Incidentally fixing a log message format
  • Updating the CHANGELOG

- Handling partial varint parsing in BTC tx parsing
- Fixing an issue when accumulating a varint raw data both in BTC tx parsing and RSK trie parsing
- Added both BTC tx and trie unit test cases
- Added an authorized signing test case to the signer tests
- Incidentally fixing a log message format
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 7b162ea into master Feb 8, 2023
@amendelzon amendelzon deleted the bugfix/btctx-partial-varint-handling branch February 8, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants