Skip to content

Commit

Permalink
Update Go test matrix to add Go v1.18
Browse files Browse the repository at this point in the history
* Update `checkout` and `setup-go` Github Actions
* Remove `golint` since its deprecated
* Drop Go v1.16
  • Loading branch information
dghubble committed Apr 12, 2022
1 parent c02e9fe commit 62be7c2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,15 @@ jobs:
strategy:
fail-fast: false
matrix:
go: ['1.16', '1.17']
go: ['1.17', '1.18']
steps:
- name: setup
uses: actions/setup-go@v2
uses: actions/setup-go@v3
with:
go-version: ${{matrix.go}}

- name: checkout
uses: actions/checkout@v2

- name: tools
run: go get golang.org/x/lint/golint
uses: actions/checkout@v3

- name: test
run: make
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.PHONY: all
all: test vet lint fmt
all: test vet fmt

.PHONY: test
test:
Expand All @@ -9,10 +9,6 @@ test:
vet:
@go vet -all .

.PHONY: lint
lint:
@golint -set_exit_status ./...

.PHONY: fmt
fmt:
@test -z $$(go fmt ./...)
Expand Down
2 changes: 1 addition & 1 deletion sling_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ func TestReceive_success_nonDefaultDecoder(t *testing.T) {
<temperature>10.5</temperature>
</response>`
fmt.Fprintf(w, xml.Header)
fmt.Fprintf(w, data)
fmt.Fprint(w, data)
})

endpoint := New().Client(client).Base("http://example.com/").Path("foo/").Post("submit")
Expand Down

0 comments on commit 62be7c2

Please sign in to comment.