Fix failure when nothing has changed in the HTML diff #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Lumos readme Note that the ĉĝĥĵŝŭ characters were added. * Update Lumos binary files --------- Co-authored-by: Y. Meyer-Norwood <[email protected]>
Signed-off-by: Y. Meyer-Norwood <[email protected]>
|
Thanks! Merged manually to ensure that the extra commit was not included. |
|
I do not see the change yet in https://github.com/rrthomas/hpmor/blob/main/.github/workflows/make.yml#L80 |
entorb
added a commit
to entorb/hpmor-de
that referenced
this pull request
Jan 17, 2025
taken from rrthomas#184
|
Thanks @entorb, I had missed out the "merging it to main locally" step, and I pushed nothing. Now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for example https://github.com/rrthomas/hpmor/actions/runs/12793679166
This failed because the
hpmor-html-diff.logfile was 0 bytes (i.e. the diff was empty due to no textual changes).The fix is to tell the
diffcommand to output "files are identical" in this case so that the log reflects this.