Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type check issue after 'apply/3' got type checking #1173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type check issue after 'apply/3' got type checking #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/credo/check.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,16 +384,19 @@ defmodule Credo.Check do
@impl true
def run_on_all_source_files(exec, source_files, params \\ [])

@impl true
def run_on_all_source_files(exec, source_files, params) do
if function_exported?(__MODULE__, :run, 3) do
if function_exported?(__MODULE__, :run, 3) do
@impl true
def run_on_all_source_files(exec, source_files, params) do
IO.warn(
"Defining `run(source_files, exec, params)` for checks that run on all source files is deprecated. " <>
"Define `run_on_all_source_files(exec, source_files, params)` instead."
)

apply(__MODULE__, :run, [source_files, exec, params])
else
end
else
@impl true
def run_on_all_source_files(exec, source_files, params) do
do_run_on_all_source_files(exec, source_files, params)
end
end
Expand Down
Loading