Added split gaussian option to fac! #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
from_split_cov
andfrom_split_sigma
methods toGaussianNoise
. Essentially these are helpers specifically for creating noises for SE2/SE3 where the scales in the variable are inherently different.Creating noises for these previously (and in other libraries) is tedious due to always having to repeat values. Instead,
GaussianNoise::from_scalar_sigmas(0.1, 0.1, 0.1, 1.0, 1.0, 1.0)
->GaussianNoise::from_split_sigmas(0.1, 1.0)
Along with this, a new option to
fac!
is added,