Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much too large PR for cleaning up a lot of the internal traits and serialization of factrs.
Specifically,
factrs::mark
that handle tagging and registering objects for serialization via serde/typetag as well as implementingResidual
for residualsimpl_residual
and all thetag_*
decl-macros. It should be more robust and easier to use.TraitSafe
traits so traits are Boxed directly instead of via a helper traitclippy::unwrap_used
and replaced most unwraps with expects.