Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorators formatting bug when using esformatter-asi #74

Open
arminrosu opened this issue Jun 1, 2016 · 2 comments
Open

Decorators formatting bug when using esformatter-asi #74

arminrosu opened this issue Jun 1, 2016 · 2 comments
Labels

Comments

@arminrosu
Copy link

arminrosu commented Jun 1, 2016

Hi,

Thanks again for fixing inline decorators :).

Found a new edges case where esformatter-jsx behaves unexpected:

.esformatter

{
    "preset": "default",
    "root": true,
    "indent": {
        "value": "  "
    },
    "plugins": [
        "esformatter-asi",
        "esformatter-jsx"

    ]
}

Input

@Decorator
export default class Example {
    constructor() {
        var a = '';
    }
}

Output

@Decorator /*__decorator__semi__open*/
/*__decorator__semi__end*/
export default class Example {
  constructor() {
    var a = ''
  }
}

I'm not sure if asi adds characters which break the replacement or there is another issue.

@royriojas
Copy link
Owner

Hi @arminrosu, sorry for this issue.

Yes we do have some issues with the interop with other esformatter plugins.

@royriojas royriojas added the bug label Jun 9, 2016
@arminrosu
Copy link
Author

As far as bugs go, this is one I can certainly live with. esformatter-jsx is a really useful project. I especially appreciate that you stay involved. Thank you!

royriojas added a commit that referenced this issue Jul 17, 2017
Fixed decorators formatting bug #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants