Add useful links in About #9720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phrasing by @Cwpute
alecpl
reviewed
Jan 12, 2025
| . 'Roundcube is free software. You can <a href="https://roundcube.net/contribute/" target="_blank">contribute to improve it</a> ' | ||
| . 'and redistribute it and/or modify it under the terms of the <a href="http://www.gnu.org/licenses/gpl.html" target="_blank">GNU General Public License</a> ' | ||
| . 'as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. ' | ||
| . 'Some <a href="https://roundcube.net/license" target="_blank">exceptions</a> for skins and plugins apply.'; | ||
| }, |
There was a problem hiding this comment.
I have a few issues with this:
- Documentation is not license, so probably would be better to separate license info from the "about and doc" info. I.e. leave the "license" content as it was, but provide an additional template handler.
- People may have the help plugin configured to direct to a different documentation URL. Maybe do not include this new element if the plugin is enabled?
- I think the "contribute" part is not needed at all.
- Providing users with more links they can follow may increase number of support request from them on our side. We don't want that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links to Roundcube, its documentation and the contribute page to the About window.
Solves #8395 and #9719