Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 warning in managesieve plugin when more than one action is configured for a rule #9174

Closed
javier-angulo opened this issue Oct 19, 2023 · 1 comment
Closed

PHP 8 warning in managesieve plugin when more than one action is configured for a rule #9174

javier-angulo opened this issue Oct 19, 2023 · 1 comment
Labels
bug C: PHP backend C: Plugins
Milestone
1.6.5

Comments

@javier-angulo
Copy link

When adding an additional action to a rule in managesieve, a php 8 warning is logged:

 PHP Deprecated:  strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/share/roundcubemail/plugins/managesieve/lib/Roundcube/rcube_sieve_engine.php on line 2780

If 3 actions are configured, 2 warnings are logged and so on.
@alecpl alecpl added this to the 1.6.5 milestone Oct 20, 2023
alecpl added a commit that referenced this issue Oct 20, 2023
@alecpl
Fix PHP warnings (#9174)
5ebaf19
alecpl added a commit that referenced this issue Oct 20, 2023
@alecpl
Fix PHP warnings (#9174)
618513a
@alecpl
Copy link
Member

alecpl commented Oct 20, 2023

Fixed.

@alecpl alecpl closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: PHP backend C: Plugins
Projects
None yet
Milestone
1.6.5
Development

No branches or pull requests
2 participants
@alecpl @javier-angulo