Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect conversion of email addresses to mailto links in plain text messages #7526

Closed
Bojo78 opened this issue Jul 31, 2020 · 3 comments
Closed

Comments

@Bojo78
Copy link

Bojo78 commented Jul 31, 2020

In plain text messages, email addresses enclosed in single quotes are incorrectly converted to mailto links on message preview.
For example:

'[email protected]'

is converted to

<a href="mailto:'[email protected]" onclick="return rcmail.command('compose','\'[email protected]',this)">'[email protected]</a> - leading ' is added to the mailto link.

image

Roundcube 1.3 & 1.4

@alecpl alecpl added this to the 1.4.8 milestone Jul 31, 2020
@alecpl
Copy link
Member

alecpl commented Jul 31, 2020

Confirmed.

@alecpl
Copy link
Member

alecpl commented Jul 31, 2020

Problem here is that an apostrophe character is a valid character in a local part of the email address. We have to make the rules more strict for this use case.

@alecpl
Copy link
Member

alecpl commented Aug 7, 2020

Fixed.

@alecpl alecpl closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants