Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect rewriting of html internal links #7512

Closed
drboone opened this issue Jul 27, 2020 · 2 comments
Closed

Incorrect rewriting of html internal links #7512

drboone opened this issue Jul 27, 2020 · 2 comments
Labels
bug C: Mail view
Milestone
1.4.8

Comments

@drboone
Copy link

drboone commented Jul 27, 2020 •
edited
Loading

Roundcube rewrites ids in e.g. div tags for obvious reasons. But these are sometimes used as targets of internal links, yet Roundcube does not also rewrite the hrefs in the a tags.

HTML from email:

<li><a href="#6277138">CFP (Journal): Special Issue: ‘Historicising the perpetrators of sexual violence: global perspectives’ (Deadline 31 October 2020)</a></li>

...

<div id="6277138" class="digest-row">

HTML sent to browser by Roundcube:

<li><a href="#6277138">CFP (Journal): Special Issue: 'Historicising the perpetrators of sexual violence: global perspectives' (Deadline 31 October 2020)</a></li>

...

<div id="v16277138" class="v1digest-row">
@alecpl alecpl added this to the 1.4.8 milestone Jul 28, 2020
alecpl added a commit that referenced this issue Jul 29, 2020
@alecpl
Fix incorrect rewriting of internal links in HTML content (#7512)
0d9bffa
alecpl added a commit that referenced this issue Jul 29, 2020
@alecpl
Fix incorrect rewriting of internal links in HTML content (#7512)
f5b9e4d
@alecpl
Copy link
Member

alecpl commented Jul 29, 2020

Fixed.

@alecpl alecpl closed this as completed Jul 29, 2020
@drboone
Copy link
Author

drboone commented Jul 29, 2020

Thanks, Alec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Mail view
Projects
None yet
Milestone
1.4.8
Development

No branches or pull requests
2 participants
@drboone @alecpl