Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percolate --use-feature from req file upwards #2

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Percolate --use-feature from req file upwards #2

merged 1 commit into from
Jul 25, 2020

Conversation

sbidoul
Copy link

@sbidoul sbidoul commented Jul 25, 2020

No description provided.

@sbidoul
Percolate --use-feature from req file upwards
38fe3c2 
We explicitly propagate --use-feature options from req files upwards.
This is not strictly necessary for the option to be enabled, because
of the default value is a global list, but that implicit behaviour is
certainly accidental, so we make it explicit, with a test.
@sbidoul sbidoul mentioned this pull request Jul 25, 2020
Merged
atugushev
atugushev approved these changes Jul 25, 2020
View reviewed changes
Copy link

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rouge8 rouge8 merged commit e399b12 into rouge8:use-feature-requirements-file Jul 25, 2020
@sbidoul sbidoul deleted the use-feature-test branch July 27, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atugushev atugushev atugushev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbidoul @atugushev @rouge8