Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try to unwrap external errors during error wrapping #80

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

morningvera
Copy link
Member

closes #37

@morningvera morningvera added the enhancement New feature or request label Mar 3, 2020
@morningvera morningvera requested a review from sum2000 March 3, 2020 17:54
@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #80 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   98.85%   98.91%   +0.06%     
==========================================
  Files           3        3              
  Lines         261      277      +16     
==========================================
+ Hits          258      274      +16     
  Misses          1        1              
  Partials        2        2
Impacted Files Coverage Δ
eris.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9953c63...edcee96. Read the comment docs.

@sum2000
Copy link
Member

sum2000 commented Mar 5, 2020

I am on the fence about this approach, it feels forced and hard to manage, makes me think if we really should support it if this is the only way to do it

@sum2000 sum2000 self-requested a review March 16, 2020 17:01
@morningvera morningvera merged commit f16804a into master Mar 17, 2020
@morningvera morningvera deleted the feat/ext-errors branch March 17, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpack external errors (especially coming from pkg/errors)
3 participants