Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try to unwrap external errors during error wrapping #78

Closed
wants to merge 1 commit into from

Conversation

morningvera
Copy link
Member

closes #37

@morningvera morningvera added the enhancement New feature or request label Feb 21, 2020
@morningvera morningvera requested a review from sum2000 February 21, 2020 20:10
@morningvera
Copy link
Member Author

Codecov Report

Merging #78 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   98.85%   98.90%   +0.05%     
==========================================
  Files           3        3              
  Lines         261      274      +13     
==========================================
+ Hits          258      271      +13     
  Misses          1        1              
  Partials        2        2              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a31a5fe...fc17485. Read the comment docs.

@morningvera
Copy link
Member Author

I still want to add an example showing this working with pkg/errors. Since their Unwrap method doesn't work as expected, I'll probably need to make some small change to make it work. No need to review until that's done.

@morningvera
Copy link
Member Author

I also want to add test cases to stack_test.go and just discovered I need to fix some bugs. Seems like there's too much left to do so I'm closing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpack external errors (especially coming from pkg/errors)
1 participant