Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: insert frames during error wrapping instead of unpacking #70

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

morningvera
Copy link
Member

No description provided.

@morningvera morningvera added the refactor Improvements to existing functionality label Jan 27, 2020
@morningvera morningvera added this to the v0.3.0 milestone Jan 27, 2020
@morningvera morningvera requested a review from sum2000 January 27, 2020 19:44
@morningvera morningvera force-pushed the refactor/insert-frames branch 2 times, most recently from f4c151a to 3228cd0 Compare January 27, 2020 20:02
@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #70 into master will increase coverage by 4%.
The diff coverage is 91.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
+ Coverage   89.54%   93.54%   +4%     
=======================================
  Files           3        3           
  Lines         287      248   -39     
=======================================
- Hits          257      232   -25     
+ Misses         19        9   -10     
+ Partials       11        7    -4
Impacted Files Coverage Δ
eris.go 100% <100%> (ø) ⬆️
format.go 91.3% <100%> (-1.08%) ⬇️
stack.go 86.66% <84.84%> (+18.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e63388...877f89e. Read the comment docs.

@morningvera morningvera force-pushed the refactor/insert-frames branch 2 times, most recently from 7bb2cbf to 3fefc2d Compare January 31, 2020 15:34
sum2000
sum2000 previously approved these changes Feb 5, 2020
Copy link
Member

@sum2000 sum2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morningvera morningvera force-pushed the refactor/insert-frames branch from 3fefc2d to 877f89e Compare February 6, 2020 16:28
@morningvera morningvera merged commit fe18b71 into master Feb 6, 2020
@morningvera morningvera deleted the refactor/insert-frames branch February 6, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants