feat: improve error wrapping, stack trace management, and formatting #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningvera
commented
Jan 7, 2020
morningvera
commented
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 95.57% 94.29% -1.28%
==========================================
Files 3 3
Lines 226 228 +2
==========================================
- Hits 216 215 -1
- Misses 8 9 +1
- Partials 2 4 +2
Continue to review full report at Codecov.
|
sum2000
requested changes
Jan 9, 2020
There was a problem hiding this comment.
I am yet to review the examples you added but I have reviewed the code. Overall I suggest that we add some comments, especially in format.go and stack.go. It is a pain but a few days from now if we look at our code we won't understand it easily without the comments.
morningvera
force-pushed
the
feat/improve-wrap-stack-trace
branch
from
fe67a73 to
0273d62
Compare
sum2000
reviewed
Jan 9, 2020
sum2000
requested changes
Jan 9, 2020
morningvera
force-pushed
the
feat/improve-wrap-stack-trace
branch
from
97e1e2c to
1784b3d
Compare
sum2000
reviewed
Jan 10, 2020
This commit includes a change to error wrapping that enables wrap error stack frames to be inserted into the root error stack trace. It also changes error formatting to display root errors first followed by wrapped errors in the same order as the stack trace (same order as runtime.Callers).
morningvera
force-pushed
the
feat/improve-wrap-stack-trace
branch
from
1784b3d to
ab35abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a change to error wrapping that enables wrap error stack frames to be inserted into the root error stack trace. It also changes error formatting to display root errors first followed by wrapped errors in the same order as the stack trace (same order as runtime.Callers).