Modifying test for failing on getting an empty node name

[CaptainTrunky]

Related to ros2/rmw_connext#362 and ros2/ros2#489.

PR modifies existing node_name_list test that it would fail on getting an empty node name.

Connects to ros2/ros2#489

[jacobperron]

Running the test without ros2/rmw_connext#362 passes normally. Unless there's a way to produce an empty node name in the test, I wonder if this change is necessary.

We can't mock an empty node name with rclcpp, since it's not allowed.

On the other hand, perhaps it's not hurting to add this additional check.

[jacobperron]

Taking another look at this, I think I misinterpreted the test. If we want to add a test checking for no empty names it seems more semantically meaningful to add it to node_check_names.cpp or put it in it's own test. The test currently being modified is meant to check that an expected node name appears in the ROS graph.

@CaptainTrunky Let me know if you're still able to iterate on this.

[jacobperron]

I've rebased on master to bring the branch up-to-date.

• Linux
• Linux-aarch64
• macOS
  • test_parameter_server_cpp failure also occurs on nightly builds.
  • test_local_parameters (OpenSplice) failure not occurring on nightly, but might not occur with release builds. In any case, the test is unrelated to the test modified in this PR.
• Windows