Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove distribute_key verb #197

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

mikaelarguedas
Copy link
Member

This verb has never been implemented and there is no plan on implementing it in the near future.
In order to streamline the API for Foxy we agreed to remove this verb completely

Signed-off-by: Mikael Arguedas <[email protected]>
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #197 into master will increase coverage by 1.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   58.31%   60.00%   +1.68%     
==========================================
  Files          18       16       -2     
  Lines         583      565      -18     
  Branches       52       52              
==========================================
- Hits          340      339       -1     
+ Misses        229      212      -17     
  Partials       14       14              
Flag Coverage Δ
#unittests 60.00% <ø> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a212b3...ed5a56b. Read the comment docs.

@mikaelarguedas mikaelarguedas merged commit 4ea3858 into ros2:master Apr 10, 2020
@mikaelarguedas mikaelarguedas deleted the remove-distribute-key branch April 10, 2020 07:27
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants