api: reorganize policy generation API #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract policy generation API from api's __init__.py and move into verb as nothing else uses it. Signed-off-by: Kyle Fazzari <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 54.96% 53.34% -1.63%
==========================================
Files 18 18
Lines 584 583 -1
Branches 52 52
==========================================
- Hits 321 311 -10
- Misses 249 258 +9
Partials 14 14
Continue to review full report at Codecov.
|
mikaelarguedas
approved these changes
Apr 8, 2020
kyrofa
commented
Apr 8, 2020
| if request_services: | ||
| self.add_permission( | ||
| profile, 'service', 'request', 'ALLOW', request_services, node_name) | ||
|
|
||
| with open(args.POLICY_FILE_PATH, 'w') as stream: | ||
| dump_policy(policy, stream) | ||
| return 0 | ||
|
|
||
|
|
||
| def _get_node_names(*, node, include_hidden_nodes=False): |
There was a problem hiding this comment.
I don't think these are more generally useful. They're very specific to this verb. Other packages will consume node names/namespaces on their own.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract policy generation API from api's
__init__.pyand move into verb. Nothing else uses it, and the verb includes a lot of related API on its own.