tests: randomize ROS_DOMAIN_ID for tests that need it #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_generate_policy_no_nodes` test appears flaky under Windows. It assumes the default DDS domain is empty of nodes, which may not always be the case. Randomize the domain ID for that test. Fix ros2#143 Signed-off-by: Kyle Fazzari <[email protected]>
|
We can't randomize the domain ID on our current infrastructure and have the test work across all platforms. Our current Windows and Mac hosts share a network and can inadvertently communicate with each other during tests if using the same domain ids. |
|
Alright, thanks @nuclearsandwich, we can scratch this attempt. It was a bit of a hack anyway-- this is sounding more like a zombie node from another test, perhaps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_generate_policy_no_nodestest appears flaky under Windows. It assumes the default DDS domain is empty of nodes, which may not always be the case. This PR attempts to fix #143 by randomizing the domain ID for that test.