Add request service permissions in generated policies #141
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddharth Kucheria <[email protected]>
Signed-off-by: Siddharth Kucheria <[email protected]>
Signed-off-by: Siddharth Kucheria <[email protected]>
Signed-off-by: Siddharth Kucheria <[email protected]>
skucheria
force-pushed
the
kucheria/request_permissions
branch
from
f9a24c7 to
90fb399
Compare
|
This looks good, and the test is lovely, thank you! However, have you verified that |
|
I tried passing a generated policy with a service server and service client running. Passing it to I think outside the scope of this PR, but it's probably worth adding integration tests to test_security for services (and actions). |
jacobperron
reviewed
Jul 8, 2019
sros2/test/sros2/commands/security/verbs/test_generate_policy.py
Outdated
Show resolved
Hide resolved
|
ruffsl
pushed a commit
to ruffsl/sros2
that referenced
this pull request
Aug 6, 2019
* added request service permissions Signed-off-by: Siddharth Kucheria <[email protected]> Signed-off-by: ruffsl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #94
Requires ros2/rclpy#383