Start porting rosidl_typesupport_fastrtps_cpp to new IDL pipeline #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @dirk-thomas I spent a little time looking at how much work it was to convert a generator by starting to convert
rosidl_typesupport_fastrtps_cpp
. The cmake portion and python code changes seem like they're at a reasonable state, but the templates themselves have not been updated.The remaining work looks like the templates will need to use the new
rosidl_parser.definition
types, and some functions__cdr_deserialize
as well as some static structs (handle
,callbacks
) will need the message name prefix.In the olde pipeline the generator would generated files
and
If I understand correctly, after conversion to the new IDL pipeline it should generate just two files for any
.idl
file