Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change generators to IDL-based pipeline #24

Merged
merged 26 commits into from
Mar 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
c20b060
update includes and type mapping
dirk-thomas Nov 21, 2018
d413fe9
map char to uint8_t
dirk-thomas Nov 24, 2018
6eefdee
update rosidl_generator_py to use IDL-based extension point
dirk-thomas Dec 3, 2018
73312eb
fix usage of service template
dirk-thomas Dec 4, 2018
3cda2af
fix Python TS symbols
dirk-thomas Dec 5, 2018
4dc23c6
minor fix
dirk-thomas Dec 5, 2018
e466173
update template list to trigger rebuilds correctly
dirk-thomas Dec 5, 2018
ee906d8
and yet another symbol fix
dirk-thomas Dec 5, 2018
0967d34
fix installation of generated Python files
dirk-thomas Dec 5, 2018
4e44dee
and fix the fix
dirk-thomas Dec 5, 2018
42f5ede
redo recent action changes to work with IDL
dirk-thomas Feb 6, 2019
d4a1e41
match renamed action types
dirk-thomas Feb 12, 2019
93d3911
fix type names
dirk-thomas Feb 14, 2019
3945683
fix symbol names
dirk-thomas Feb 14, 2019
b375421
fix imports and CMake dep
dirk-thomas Feb 14, 2019
c1d7c34
fix module name for services / actions
dirk-thomas Feb 15, 2019
bce6279
update action types
dirk-thomas Feb 16, 2019
6cbff0f
fix Python type registration
dirk-thomas Feb 16, 2019
0759419
fix import ts for action messages
dirk-thomas Feb 16, 2019
ff1723e
fix action Python type support
dirk-thomas Feb 17, 2019
d760bf0
fix action type imports
dirk-thomas Feb 17, 2019
42adce8
keep legacy slot types for now
dirk-thomas Feb 19, 2019
2c5367d
move template calls
dirk-thomas Feb 22, 2019
2b38b79
add comment
dirk-thomas Feb 22, 2019
2d2eba1
deterministic order
dirk-thomas Feb 27, 2019
b6fe934
readd explicit dependency on absolute paths of idl files
dirk-thomas Feb 28, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions rosidl_generator_py/cmake/custom_command.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
# a different CMake subdirectory, and this command is invoked after an
# add_subdirectory() call.
add_custom_command(
OUTPUT ${_generated_extension_files} ${_generated_msg_py_files} ${_generated_msg_c_files} ${_generated_srv_py_files} ${_generated_srv_c_files} ${_generated_action_py_files} ${_generated_action_c_files}
OUTPUT ${_generated_extension_files} ${_generated_py_files} ${_generated_c_files}
COMMAND ${PYTHON_EXECUTABLE} ${rosidl_generator_py_BIN}
--generator-arguments-file "${generator_arguments_file}"
--typesupport-impls "${_typesupport_impls}"
DEPENDS ${target_dependencies} ${rosidl_generate_interfaces_TARGET} ${extra_generator_dependencies}
DEPENDS ${target_dependencies} ${rosidl_generate_interfaces_TARGET}
COMMENT "Generating Python code for ROS interfaces"
VERBATIM
)
Expand All @@ -35,11 +35,7 @@ else()
${rosidl_generate_interfaces_TARGET}${_target_suffix}
DEPENDS
${_generated_extension_files}
${_generated_msg_py_files}
${_generated_msg_c_files}
${_generated_srv_py_files}
${_generated_srv_c_files}
${_generated_action_py_files}
${_generated_action_c_files}
${_generated_py_files}
${_generated_c_files}
)
endif()
7 changes: 1 addition & 6 deletions rosidl_generator_py/cmake/register_py.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,10 @@
macro(rosidl_generator_py_extras BIN GENERATOR_FILES TEMPLATE_DIR)
find_package(ament_cmake_core QUIET REQUIRED)
ament_register_extension(
"rosidl_generate_interfaces"
"rosidl_generate_idl_interfaces"
"rosidl_generator_py"
"rosidl_generator_py_generate_interfaces.cmake")

ament_register_extension(
"rosidl_generate_action_interfaces"
"rosidl_generator_py"
"rosidl_generator_py_generate_action_interfaces.cmake")

normalize_path(BIN "${BIN}")
set(rosidl_generator_py_BIN "${BIN}")

Expand Down

This file was deleted.

Loading