Uniform cmake minVersion #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
3.20 seems fine to me because it's less than the minimum required by ROS Kilted
|
@mosfet80 It looks like the DCO check is failing. Please sign off your commit using the instructions at https://github.com/ros2/rosidl/pull/849/checks?check_run_id=37701938818 |
With the latest versions of cmake, the deprecation of cmake versions <=3.10 is reported. From a brief analysis of the idl library, there are non-homogeneous versions of CMAKE. The patch standardizes the minimum required cmake version, which therefore becomes 3.20 "rosidl_generator_c/cmake/rosidl_generator_c_generate_interfaces.cmake" Signed-off-by: Andrea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest versions of cmake, the deprecation of cmake versions <=3.10 is reported. From a brief analysis of the idl library, there are non-homogeneous versions of CMAKE_MIN_VERSION. The patch standardizes the minimum required cmake version, which therefore becomes 3.20 "rosidl_generator_c/cmake/rosidl_generator_c_generate_interfaces.cmake"