Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition for including resize functions #379

Merged
merged 1 commit into from
May 14, 2019

Conversation

jacobperron
Copy link
Member

Resolves #378

Bug introduced by #334.

Bug introduced by #334.

Signed-off-by: Jacob Perron <[email protected]>
@jacobperron
Copy link
Member Author

jacobperron commented May 14, 2019

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Edit: re-triggered with Fast-RTPS at tag v1.7.2

@jacobperron
Copy link
Member Author

jacobperron commented May 14, 2019

The windows warning is unrelated, coming from fastrtps, because the version does not have the following fix eProsima/Fast-DDS#489.

@jacobperron jacobperron merged commit 6f8194a into master May 14, 2019
@jacobperron jacobperron deleted the jacob/fix_logic_bug branch May 14, 2019 18:32
@jacobperron jacobperron removed the in progress Actively being worked on (Kanban column) label May 14, 2019
malsbat added a commit to malsbat/rosidl that referenced this pull request May 14, 2019
dirk-thomas pushed a commit that referenced this pull request May 14, 2019
@dirk-thomas dirk-thomas added the bug Something isn't working label May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resize_function is NULL for ParameterEvent new_parameters, changed_parameters, deleted_parameters
2 participants