XML launch files are still supported in ROS2 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this also mention YAML? I saw in the source code that there is also a YAML frontend.
Yeah, the YAML frontend is also supported. I think it would be nice to mention that as well. |
|
Ok, done. |
clalancette
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Looks good to me, thanks for the patch. @maryaB-osr please merge when you get a chance.
|
@Mergifyio backport rolling |
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950)
|
Command
|
maryaB-osr
pushed a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda)
mergify bot
added a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda)
mergify bot
added a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda)
maryaB-osr
pushed a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maryaB-osr
pushed a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maryaB-osr
pushed a commit
that referenced
this pull request
Dec 17, 2020
* XML launch files are still supported in ROS2 Should this also mention YAML? I saw in the source code that there is also a YAML frontend. * Shorten long sentence * Add "and YAML" (cherry picked from commit e86c950) Co-authored-by: Nikolai Morin <[email protected]> (cherry picked from commit 9050eda) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this also mention YAML? I saw in the source code that there also seems to be a YAML frontend.