New tutorial for service/client with Python #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maryaB-osr <[email protected]>
Signed-off-by: maryaB-osr <[email protected]>
Signed-off-by: maryaB-osr <[email protected]>
sloretz
reviewed
Oct 23, 2019
Signed-off-by: maryaB-osr <[email protected]>
|
@sloretz I think I fixed all the indentation problems. Let me know if it's good to merge! |
sloretz
reviewed
Oct 24, 2019
Signed-off-by: Shane Loretz <[email protected]>
sloretz
approved these changes
Oct 24, 2019
Signed-off-by: maryaB-osr <[email protected]>
maryaB-osr
added a commit
that referenced
this pull request
Oct 25, 2019
* Environment config tutorial (#334) * Environment config tutorial Signed-off-by: maryaB-osr <[email protected]> * Added pages to some empty links for CI check Signed-off-by: maryaB-osr <[email protected]> * Add requirements.txt and app.json for Heroku build (#336) This enables heroku "review apps" Signed-off-by: Michael Carroll <[email protected]> * Addressed reviews and implemented tabs Signed-off-by: maryaB-osr <[email protected]> * Added tabs install instructions for travis Signed-off-by: maryaB-osr <[email protected]> * Fixed Travis warnings Signed-off-by: maryaB-osr <[email protected]> * Prereqs note about using debs. for linux Signed-off-by: maryaB-osr <[email protected]> * Added reference for linking Signed-off-by: maryaB-osr <[email protected]> * Update Goal statement Co-Authored-By: Jacob Perron <[email protected]> * Remove leading arrowhead from Windows command Co-Authored-By: Jacob Perron <[email protected]> * Empty line before .. todo: Co-Authored-By: Jacob Perron <[email protected]> * "value" to "integer" for ROS_DOMAIN_ID Co-Authored-By: Jacob Perron <[email protected]> * Added ROS_DOMAIN_ID explanation Signed-off-by: maryaB-osr <[email protected]> * Link to ROS Answers Also left a note to test Windows domain ID command Signed-off-by: maryaB-osr <[email protected]> * Syntax error on ROS answers link Signed-off-by: maryaB-osr <[email protected]> * Changed domainID tabs to include script command Signed-off-by: maryaB-osr <[email protected]> * Fixed too much indentation Signed-off-by: maryaB-osr <[email protected]> * Update Windows ROS_DOMAIN_ID config section (#341) * Update Windows ROS_DOMAIN_ID config section Signed-off-by: Jacob Perron <[email protected]> * Update source/Tutorials/ConfiguringROS2Environment.rst Co-Authored-By: Chris Lalancette <[email protected]> * New tutorial for introducing turtlesim for ROS 2 (#342) * New tutorial for introducing turtlesim for ROS 2 Signed-off-by: maryaB-osr <[email protected]> * Trying one image Signed-off-by: maryaB-osr <[email protected]> * New file not included in toctree Signed-off-by: maryaB-osr <[email protected]> * All images and fix toctree (?) Signed-off-by: maryaB-osr <[email protected]> * More concise goal statement Co-Authored-By: Chris Lalancette <[email protected]> * Update Windows ROS_DOMAIN_ID config section (#341) * Update Windows ROS_DOMAIN_ID config section Signed-off-by: Jacob Perron <[email protected]> * Update source/Tutorials/ConfiguringROS2Environment.rst Co-Authored-By: Chris Lalancette <[email protected]> * Removed ros2 run explanation (for next tutorial) Signed-off-by: maryaB-osr <[email protected]> * "turtled" to "turtle" Co-Authored-By: Chris Lalancette <[email protected]> * clalancette's requested changes Signed-off-by: maryaB-osr <[email protected]> * dirk-thomas's requested changes Signed-off-by: maryaB-osr <[email protected]> * forgot to remove "2" from file name Signed-off-by: maryaB-osr <[email protected]> * fixed backticks and added sentence about pen Signed-off-by: maryaB-osr <[email protected]> * corrections from dirk-thomas Signed-off-by: maryaB-osr <[email protected]> * New tutorial on ROS 2 topics (#344) * New tutorial on ROS 2 topics Signed-off-by: maryaB-osr <[email protected]> * removed random ? Signed-off-by: maryaB-osr <[email protected]> * comment out empty reference Signed-off-by: maryaB-osr <[email protected]> * remove "on" Co-Authored-By: Chris Lalancette <[email protected]> * clarify topics definition Co-Authored-By: Chris Lalancette <[email protected]> * "process" > "topic" Co-Authored-By: Chris Lalancette <[email protected]> * reword "command line introspection" Co-Authored-By: William Woodall <[email protected]> * properly name topics and nodes Co-Authored-By: William Woodall <[email protected]> * clarify not all robots need a data stream Co-Authored-By: William Woodall <[email protected]> * typo "you" > "your" Co-Authored-By: William Woodall <[email protected]> * address comments on definition of topics Signed-off-by: maryaB-osr <[email protected]> * Rearrange background info Signed-off-by: maryaB-osr <[email protected]> * typo Co-Authored-By: Chris Lalancette <[email protected]> * minor edits Signed-off-by: maryaB-osr <[email protected]> * New tutorial on ROS 2 services (#346) * New tutorial on ROS 2 services Signed-off-by: maryaB-osr <[email protected]> * adding links on turtlesim, config, topics Signed-off-by: maryaB-osr <[email protected]> * removed cluttered parameter services Signed-off-by: maryaB-osr <[email protected]> * YAML syntax only on cmd line Co-Authored-By: Chris Lalancette <[email protected]> * specified synchronous services will wait Signed-off-by: maryaB-osr <[email protected]> * single quotes inside double quotes Co-Authored-By: Scott K Logan <[email protected]> * addressed cottsay's reviews Signed-off-by: maryaB-osr <[email protected]> * more intuitive topics/services description Signed-off-by: maryaB-osr <[email protected]> * more concise wording Co-Authored-By: Chris Lalancette <[email protected]> * missing comma Co-Authored-By: Chris Lalancette <[email protected]> * typo Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ROS 2 parameters (#347) * New tutorial for ROS 2 parameters Signed-off-by: maryaB-osr <[email protected]> * Forgot toctree and goal statement Signed-off-by: maryaB-osr <[email protected]> * italics > bold Signed-off-by: maryaB-osr <[email protected]> * small edits based on reviews Signed-off-by: maryaB-osr <[email protected]> * Change the main README to say to use pip for sphinx and required sphinx-tab installation. (#363) Add sphinx and sphinx-tab into requirements.txt Clarify to use pip3 so people implicitly know that python3 is required Further clarify sphinx requirements * New tutorial for ROS 2 nodes (#343) * New tutorial for ROS 2 nodes Signed-off-by: maryaB-osr <[email protected]> * commented out empty reference (for now) Also added link target to concept overview page Signed-off-by: maryaB-osr <[email protected]> * removed pic link, added code blocks Signed-off-by: maryaB-osr <[email protected]> * "Hopefully" sounds silly Co-Authored-By: Chris Lalancette <[email protected]> * "multiple nodes" to "one or more" Co-Authored-By: Chris Lalancette <[email protected]> * added node info with actions Signed-off-by: maryaB-osr <[email protected]> * added links for prereqs and next steps Signed-off-by: maryaB-osr <[email protected]> * fixed node def & added design doc link Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ROS 2 actions (#350) * New tutorial for ROS 2 actions Signed-off-by: maryaB-osr <[email protected]> * travis warning Signed-off-by: maryaB-osr <[email protected]> * explicitly describe action goal process Co-Authored-By: Jacob Perron <[email protected]> * correct services definition Co-Authored-By: Jacob Perron <[email protected]> * correct implemenation details Co-Authored-By: Jacob Perron <[email protected]> * cancel > preempt Co-Authored-By: Jacob Perron <[email protected]> * minor updates Signed-off-by: maryaB-osr <[email protected]> * jacobperron's review Signed-off-by: maryaB-osr <[email protected]> * Changed `action show` to `interface show` Signed-off-by: maryaB-osr <[email protected]> * updated hidden actions in node info & removed bash Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ROS 2 rqt_console (#351) * New tutorial for ROS 2 rqt_console Signed-off-by: maryaB-osr <[email protected]> * missing spaces in topic pub yaml Co-Authored-By: Michel Hidalgo <[email protected]> * change tense Co-Authored-By: Michel Hidalgo <[email protected]> * first > top Co-Authored-By: Chris Lalancette <[email protected]> * specify new terminal Co-Authored-By: Chris Lalancette <[email protected]> * change file names and add links to prereqs Signed-off-by: maryaB-osr <[email protected]> * minor changes from reviews Signed-off-by: maryaB-osr <[email protected]> * addressed reviews Signed-off-by: maryaB-osr <[email protected]> * typo + updated remapping syntax Signed-off-by: maryaB-osr <[email protected]> * Updated remapping syntax (#354) * Updated remapping syntax Signed-off-by: maryaB-osr <[email protected]> * tabs for eloquent/dashing remap syntax Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ROS 2 bag files (#355) * New tutorial for ROS 2 bag files Signed-off-by: maryaB-osr <[email protected]> * trying to make alt-text for internal links work Signed-off-by: maryaB-osr <[email protected]> * added available links Signed-off-by: maryaB-osr <[email protected]> * addressed reviews Signed-off-by: maryaB-osr <[email protected]> * New tutorial for creating a workspace (#359) * New tutorial for creating a workspace Signed-off-by: maryaB-osr <[email protected]> * typo Signed-off-by: maryaB-osr <[email protected]> * typo Co-Authored-By: Chris Lalancette <[email protected]> * addressed reviews (dirk-thomas & clalancette) Signed-off-by: maryaB-osr <[email protected]> * revert source paths until PR 380 merges Signed-off-by: maryaB-osr <[email protected]> * underlay != main installation Co-Authored-By: Tully Foote <[email protected]> * main source not mandatory Co-Authored-By: Tully Foote <[email protected]> * underlay != main installation (again) Co-Authored-By: Tully Foote <[email protected]> * tfoote and clalancette suggestions Signed-off-by: maryaB-osr <[email protected]> * trailing whitespace Signed-off-by: maryaB-osr <[email protected]> * New tutorial for creating a package in ROS 2 (#362) * New tutorial for creating a package in ROS 2 Signed-off-by: maryaB-osr <[email protected]> * addressed review from ivanpauno & sloretz Signed-off-by: maryaB-osr <[email protected]> * ivan's final review Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ros2doctor (#378) * New tutorial for ros2doctor Signed-off-by: maryaB-osr <[email protected]> * linter Signed-off-by: maryaB-osr <[email protected]> * claireyywang's review Signed-off-by: maryaB-osr <[email protected]> * New tutorial for service and client using C++ (#370) * new tutorial for service and client using C++ Signed-off-by: maryaB-osr <[email protected]> * linter fix Signed-off-by: maryaB-osr <[email protected]> * linter Signed-off-by: maryaB-osr <[email protected]> * forgot package name in pkg create Signed-off-by: maryaB-osr <[email protected]> * improve sentence structure Co-Authored-By: Michel Hidalgo <[email protected]> * minor changes Signed-off-by: maryaB-osr <[email protected]> * target > targets * Update parameters tutorial (#384) * Update parameters tutorial Signed-off-by: maryaB-osr <[email protected]> * linter Signed-off-by: maryaB-osr <[email protected]> * New tutorial for Python pub/sub (#364) * New tutorial for Python pub/sub Signed-off-by: maryaB-osr <[email protected]> * fix linter issue Signed-off-by: maryaB-osr <[email protected]> * removed mentions of line numbers, plus other reviews Signed-off-by: maryaB-osr <[email protected]> * removed comments from long code blocks Signed-off-by: maryaB-osr <[email protected]> * removed parenthesis from file names Signed-off-by: maryaB-osr <[email protected]> * final nits Signed-off-by: maryaB-osr <[email protected]> * macOS users already have dependencies installed Signed-off-by: maryaB-osr <[email protected]> * Consistent indentation in code blocks Signed-off-by: Shane Loretz <[email protected]> * unneeded codeblock line Signed-off-by: maryaB-osr <[email protected]> * New tutorial for service/client with Python (#372) * New tutorial for service/client with Python Signed-off-by: maryaB-osr <[email protected]> * title underline too short Signed-off-by: maryaB-osr <[email protected]> * trailing whitespace Signed-off-by: maryaB-osr <[email protected]> * fix indentation and other nits Signed-off-by: maryaB-osr <[email protected]> * Consistent indentation in code blocks Signed-off-by: Shane Loretz <[email protected]> * wrong section Signed-off-by: maryaB-osr <[email protected]> * New tutorial for ROS 2 launch files (#353) * New tutorial for ROS 2 launch files Signed-off-by: maryaB-osr <[email protected]> * Forgot to include in toctree Signed-off-by: maryaB-osr <[email protected]> * trailing white space Signed-off-by: maryaB-osr <[email protected]> * missing period Co-Authored-By: Chris Lalancette <[email protected]> * inside pkg > provided by pkg Co-Authored-By: Michel Hidalgo <[email protected]> * python modules explanation Co-Authored-By: Michel Hidalgo <[email protected]> * handful of reviews Signed-off-by: maryaB-osr <[email protected]> * linter & added next steps to rqt_console Signed-off-by: maryaB-osr <[email protected]> * more trailing whitespaces... Signed-off-by: maryaB-osr <[email protected]> * trying linenos Signed-off-by: maryaB-osr <[email protected]> * adjust indented space on linenos Signed-off-by: maryaB-osr <[email protected]> * another attempt at linenos indentation Signed-off-by: maryaB-osr <[email protected]> * change indentation Signed-off-by: maryaB-osr <[email protected]> * fix indentation on python block Signed-off-by: maryaB-osr <[email protected]> * give up on linenos for now Signed-off-by: maryaB-osr <[email protected]> * fixed indentation...? Signed-off-by: maryaB-osr <[email protected]> * New tutorial for C++ pub/sub (#366) * New tutorial for C++ pub/sub Signed-off-by: maryaB-osr <[email protected]> * try C++ code highlighting Signed-off-by: maryaB-osr <[email protected]> * one incorrect directive Signed-off-by: maryaB-osr <[email protected]> * fixed some indentation Signed-off-by: maryaB-osr <[email protected]> * changed entry points to executables Signed-off-by: maryaB-osr <[email protected]> * removed parenthesis from file name Signed-off-by: maryaB-osr <[email protected]> * New branch for cleaning up staging This commit organizes the order of the tutorials, adds an introduction to the beginner tutorials, and hyphenates all the page names Signed-off-by: maryaB-osr <[email protected]> * added next steps sections and other internal links Signed-off-by: maryaB-osr <[email protected]> * change msg show to interface show Signed-off-by: maryaB-osr <[email protected]> * linter Signed-off-by: maryaB-osr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sloretz I just changed the client to take input instead of having fixed integers, so if you could check that to make sure it's correct (I tested and it works)
Signed-off-by: maryaB-osr [email protected]