enhance parameter bridge enable options for topics #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzodepedro
reviewed
May 1, 2020
daisukes
force-pushed
the
enhance-parameter-bridge
branch
from
2401db5 to
ce54891
Compare
fujitatomoya
requested changes
May 7, 2020
|
|
dirk-thomas
reviewed
May 20, 2020
|
@daisukes Friendly ping. |
|
@dirk-thomas Thank you for the reminder. I will work on this today. |
|
Do I need to fix the conflict too? |
…ent_local, reliable, and latch) Signed-off-by: Daisuke Sato <[email protected]>
Signed-off-by: Daisuke Sato <[email protected]>
Signed-off-by: Daisuke Sato <[email protected]>
Signed-off-by: Daisuke Sato <[email protected]>
daisukes
force-pushed
the
enhance-parameter-bridge
branch
from
51ceace to
2ab5c92
Compare
dirk-thomas
reviewed
Jun 5, 2020
Signed-off-by: Daisuke Sato <[email protected]>
Signed-off-by: Daisuke Sato <[email protected]>
fujitatomoya
approved these changes
Jun 8, 2020
|
ros2/design#296 aims to provide a way to configure the QoS from the outside in a generic way. With that approach being the preferred choice I don't think a custom way to configure the bridge is desired. |
dirk-thomas
added
duplicate
|
Linking updated configurable QoS proposal ros2/design#300 |
|
@daisukes does the added functionality satisfy your use case? If so, you may go ahead and close this. |
|
@hidmic, yes for ROS2 galactic. I may want to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement enables parameter_bridge to control the bridge precisely with the following keys. Please see the detail in doc/parameter_bridge.rst
I was struggling with tf_static which is a latched topic in ROS1 but cannot be seen in ROS2.
With specifying transient_local and reliable to true, it can be seen in ROS2 like a latched topic (of course need to use transient_local and reliable for the subscriber).
Signed-off-by: Daisuke Sato [email protected]