This repository was archived by the owner on Oct 7, 2021. It is now read-only.
update to support new rmw API with namespaces #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
added
enhancement
Karsten1987
approved these changes
Apr 5, 2017
dirk-thomas
approved these changes
Apr 5, 2017
Merged
dirk-thomas
reviewed
Sep 1, 2017
| @@ -202,6 +206,13 @@ rmw_create_node(const char * name, size_t domain_id) | |||
| } | |||
| memcpy(const_cast<char *>(node->name), name, strlen(name) + 1); | |||
|
|
|||
| node->namespace_ = reinterpret_cast<const char *>(rmw_allocate(sizeof(char) * strlen(namespace_) + 1)); | |||
There was a problem hiding this comment.
This memory is never freed. See #194.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#95