Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement test for subscription loaned messages #186

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Implement test for subscription loaned messages #186

merged 3 commits into from
Apr 13, 2021

Conversation

MiguelCompany
Copy link
Contributor

While testing ros2/rmw_fastrtps#523 I discovered these non-implemented tests

This PR provides an implementation for them.

@MiguelCompany MiguelCompany mentioned this pull request Apr 13, 2021
Merged
clalancette
clalancette approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional tests, this looks good to me assuming CI is happy.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mjcarroll mjcarroll merged commit 0890417 into ros2:master Apr 13, 2021
@MiguelCompany MiguelCompany deleted the test-subscription-loans branch April 14, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @clalancette @mjcarroll