Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer maintenance to Simon #85

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Transfer maintenance to Simon #85

merged 1 commit into from
Jan 25, 2023

Conversation

Karsten1987
Copy link
Collaborator

No description provided.

@mossmaurice
Copy link
Collaborator

@Karsten1987 Thanks for the PR!

Unfortunately, ament_xmllint doesn't like it:

Error: /home/runner/work/rmw_iceoryx/rmw_iceoryx/rmw_iceoryx_cpp/package.xml:7: element author: Schemas validity error : Element 'author': This element is not expected. Expected is ( maintainer ).

Could you change it to two <maintainer> entries and update it to your current email address? Thanks 🙏

FYI @budrus @ralph-lange As we discussed this morning.

@mossmaurice mossmaurice added the documentation Improvements or additions to documentation label Jan 25, 2023
@mossmaurice mossmaurice changed the base branch from galactic to humble January 25, 2023 15:06
@mossmaurice mossmaurice changed the base branch from humble to galactic January 25, 2023 15:06
@Karsten1987
Copy link
Collaborator Author

Is the linter not working correctly then?
https://ros.org/reps/rep-0140.html#author-multiple allows an author tag in its definition.

@mjcarroll
Copy link
Member

mjcarroll commented Jan 25, 2023 •
edited
Loading

I believe that you need at least one <author> tag. Typically we move the maintainers to authors when passing off.

@mossmaurice
Copy link
Collaborator

mossmaurice commented Jan 25, 2023 •
edited
Loading

@Karsten1987 Can you try swapping the lines with <author> and <maintainer>? AFAIU the ordering is defined in the XML schema and <maintainer> has to come first.

ralph-lange
ralph-lange approved these changes Jan 25, 2023
View reviewed changes
Copy link

@ralph-lange ralph-lange left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but commit needs sign-off. And the author tag has to be put after the license tag.

@Karsten1987
Transfer maintenance to Simon
325618f 
Signed-off-by: Karsten Knese <[email protected]>
@Karsten1987 Karsten1987 merged commit bed11c3 into galactic Jan 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the Karsten1987-patch-1 branch January 25, 2023 21:47
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Jan 25, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
12b01d6
@mossmaurice mossmaurice mentioned this pull request Jan 25, 2023
Merged
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Jan 25, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
7ee7295
@mossmaurice mossmaurice mentioned this pull request Jan 25, 2023
Merged
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Jan 25, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
9b65c99 
Signed-off-by: Karsten Knese <[email protected]>
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Jan 25, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
3a6abea 
Signed-off-by: Karsten Knese <[email protected]>
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Jan 30, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
01ecb34 
Signed-off-by: Karsten Knese <[email protected]>
mossmaurice pushed a commit that referenced this pull request Jan 31, 2023
@mossmaurice-apexai @Karsten1987
Transfer maintenance to Simon (#85) (#86)
c2348ff 
Signed-off-by: Karsten Knese <[email protected]>
Co-authored-by: Karsten Knese <[email protected]>
mossmaurice pushed a commit to ApexAI/rmw_iceoryx that referenced this pull request Mar 21, 2023
@Karsten1987 @mossmaurice-apexai
Transfer maintenance to Simon (ros2#85)
9c14ef0 
Signed-off-by: Karsten Knese <[email protected]>
mossmaurice pushed a commit that referenced this pull request Mar 21, 2023
@mossmaurice-apexai @Karsten1987
Transfer maintenance to Simon (#85) (#87)
590037d 
Signed-off-by: Karsten Knese <[email protected]>
Co-authored-by: Karsten Knese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralph-lange ralph-lange ralph-lange approved these changes

@mossmaurice mossmaurice Awaiting requested review from mossmaurice

Assignees

@Karsten1987 Karsten1987

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karsten1987 @mossmaurice @mjcarroll @ralph-lange