Adding namespaces

[richiware]

We removed in Fast-RTPS a using eprosima::fastrtps and a using eprosima::fastrtps::rtps located in a header file. Some users have had problem with this. This PR resolves compilation errors before upload our commit to Github.

[mikaelarguedas]

Thanks @richiware for the headsup.

We removed in Fast-RTPS a using eprosima::fastrtps and a using eprosima::fastrtps::rtps located in a header file. Some users have had problem with this. This PR resolves compilation errors before upload our commit to Github.

Is this commit available somewhere on the Fast-RTPS Github repository for us to test?

This PR currently violates our styleguide and will fail the tests. I have a similar set of commit on this branch that I think adress the same problem and I'd like to test against your namespace removal.

[richiware]

@mikaelarguedas Three months ago a fellow worker made changes in our internal develop branch to solve a problem with namespaces. This week we decided to merge this changes in our internal master branch. I don't want to upload it to Github before be sure not break ROS2.

Today I tested our internal master branch (with the fixing in namespaces) with ROS2 and rmw_fastrtps didn't compile. I was not aware about your changes and decided to upload a PR that solves the problem. But you can deny it.

I've pushed to Github our internal master branch in a new branch for helping you to test.

[mikaelarguedas]

Thanks @richiware for being proactive on this! and for pushing a branch with the changes for us to test 👍. Unfortunately it currently doesnt compile.
I opened #196 with similar changes, I will comment here as soon as #196 is ready to be merged so that you can roll out your changes in Fast-RTPS.

[mikaelarguedas]

@richiware #196 has been merged so rmw_fastrtps_cpp should work with the new namespace changes.

Thanks!

[richiware]

I've updated our master branch.

[mikaelarguedas]

thanks @richiware for the follow-up