Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmw_fastrtps_dynamic_cpp shouldn't require rosidl_typesupport_fastrtps_* #382

Closed
ivanpauno opened this issue May 12, 2020 · 4 comments · Fixed by #740
Closed

rmw_fastrtps_dynamic_cpp shouldn't require rosidl_typesupport_fastrtps_* #382

ivanpauno opened this issue May 12, 2020 · 4 comments · Fixed by #740
Labels
backlog enhancement New feature or request help wanted Extra attention is needed

Comments

@ivanpauno
Copy link
Member

Feature request

Feature description

Currently, it's impossible to make a single rmw single typesupport build for rmw_fastrtps_dynamic_cpp, as it currently depends on rosidl_typesupport_fastrtps_c/cpp:

<build_depend>rosidl_typesupport_introspection_c</build_depend>
<build_depend>rosidl_typesupport_introspection_cpp</build_depend>

That dependency was introduced to use some utility functions available there.
It could be removed if the utility functions are moved to a common package.

@MiguelCompany
Copy link
Collaborator

That dependency was introduced to use some utility functions available there.
It could be removed if the utility functions are moved to a common package

The dependency is there just for the u16string <-> wstring conversions. Perhaps rosidl_runtime_c and/or rosidl_runtime_cpp are good candidates for those functions?

@ivanpauno
Copy link
Member Author

Sounds good to me

@ZhenshengLee
Copy link

Can be closed?

@MiguelCompany
Copy link
Collaborator

I don't think so, since rmw_fastrtps_dynamic_cpp still requires rosidl_typesupport_fastrtps_* here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants