This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add function for getting clients by node #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcarroll
reviewed
Jun 27, 2019
| node_name, | ||
| node_namespace, | ||
| service_names_and_types, | ||
| "Reply"); |
There was a problem hiding this comment.
I know this is the last review of the set, but I just considered that maybe the "Reply" and "Request" should be some sort of static const, so that we don't have to update them if something changes?
There was a problem hiding this comment.
Yeah, that's a good idea. What about #define them in names_and_types_helpers.hpp?
There was a problem hiding this comment.
If you're okay with it, I can do this refactoring in a follow-up set of PRs, since this can be done in all of the rmw implementations.
Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Jacob Perron <[email protected]>
jacobperron
force-pushed
the
jacob/get_clients_by_node
branch
from
585b287 to
f7fd64f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#179