This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Add function to get publisher actual qos settings #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivanpauno <[email protected]>
hidmic
approved these changes
Mar 28, 2019
| } | ||
| DDS::DataWriterQos dds_qos; | ||
| DDS::ReturnCode_t status = data_writer->get_qos(dds_qos); | ||
| if (status != DDS::RETCODE_OK) { |
There was a problem hiding this comment.
@ivanpauno literal go on the left for comparisons, per our C style guide.
| DDS::DataWriterQos dds_qos; | ||
| DDS::ReturnCode_t status = data_writer->get_qos(dds_qos); | ||
| if (status != DDS::RETCODE_OK) { | ||
| RMW_SET_ERROR_MSG("publisher internal can't get data writer qos policies"); |
There was a problem hiding this comment.
@ivanpauno extra internal ?
Signed-off-by: ivanpauno <[email protected]>
ivanpauno
added
in review
Done |
Signed-off-by: ivanpauno <[email protected]>
|
CI:
|
|
Was this supposed to be merged? The API it implements was not merged yet, as far as I can tell: ros2/rmw#169 |
|
Nevermind, I seem to have caught you mid merge. |
dabonnie
pushed a commit
to aws-ros-dev/rmw_connext
that referenced
this pull request
Apr 3, 2019
* Implement rmw_publisher_get_actual_qos in rmw_connext_cpp Signed-off-by: ivanpauno <[email protected]> * Implement rmw_publisher_get_actual_qos in rmw_connext_dynamic_cpp Signed-off-by: ivanpauno <[email protected]> Signed-off-by: Devin Bonnie <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements api added in ros2/rmw#169
Should I add an implementation for rmw_connext_dynamic_cpp? It's currently being ignored (with an AMENT_IGNORE file).
Connects to ros2/rmw#169