This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Include node namespaces in get_node_names #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwwood
reviewed
Aug 29, 2018
rmw_connext_shared_cpp/src/node.cpp
Outdated
|
|
||
| snprintf(reinterpret_cast<char *>(participant_qos.user_data.value.get_contiguous_buffer()), |
There was a problem hiding this comment.
Might be a good idea to check the return code of snprintf.
wjwwood
reviewed
Aug 29, 2018
| if (rcutils_ret != RCUTILS_RET_OK) { | ||
| RCUTILS_LOG_ERROR_NAMED( | ||
| "rmw_connext_cpp", | ||
| "failed to cleanup during error handling: %s", rcutils_get_error_string_safe()) |
There was a problem hiding this comment.
Need to reset the error message here with rcutils_reset_error().
| if (!node_namespaces->data[i]) { | ||
| RMW_SET_ERROR_MSG("could not allocate memory for node namespace") | ||
| rcutils_ret = rcutils_string_array_fini(node_names); | ||
| rcutils_ret = rcutils_string_array_fini(node_namespaces); |
There was a problem hiding this comment.
If both fail then you'll need to reset the error state between them, but then again, perhaps that's ok or even intentional.
Separately I'll say that rather than duplicating this cleanup code, I'd recommend using a label and a goto to have it happen in one place.
* Use goto to handle failure conditions. * Check snprintf return.
mjcarroll
force-pushed
the
get_node_names_and_namespaces
branch
from
c741336 to
e0d1e0d
Compare
wjwwood
approved these changes
Sep 1, 2018
dabonnie
pushed a commit
to aws-ros-dev/rmw_connext
that referenced
this pull request
Apr 3, 2019
* Include node namespaces in get_node_names. * Address reviewer feedback. * Use goto to handle failure conditions * Fix typo. Signed-off-by: Devin Bonnie <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rmw#142