Set hints to find the python version we actually want. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <[email protected]>
fujitatomoya
approved these changes
Feb 15, 2024
|
This one can go in independently of the rest, so running CI on just this:
|
|
The one failing test on Windows Debug seems to be a bit of a flake, and unrelated to this. So going ahead and merging. |
delete-merged-branch
bot
deleted the
clalancette/remove-python-cmake-module
branch
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Feb 20, 2024
)" This reverts commit 24431ba.
|
FYI, this breaks compatibility with some micro-ROS platforms due to the new CMake version: https://github.com/micro-ROS/micro_ros_espidf_component/actions/runs/7968336489/job/21754309794. Why is Python required for this package? |
There are apparently some logging macros installed by this package: https://github.com/ros2/rcutils/blob/rolling/rcutils/logging.py That said, we already require CMake 3.20+ almost across the board in https://www.ros.org/reps/rep-2000.html#jazzy-jalisco-may-2024-may-2029 (we'll be updating the places where we aren't; thanks for the reminder). And we'll be taking advantage of that in other places, like in ament/ament_cmake#508 . So I think those platforms are going to have to be updated one way or the other. |
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Mar 4, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Mar 18, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 1, 2024
)" This reverts commit 24431ba.
drensber
pushed a commit
to drensber/rcutils
that referenced
this pull request
Apr 3, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 8, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 17, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 24, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 29, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Apr 30, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jun 5, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jun 6, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jun 18, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jul 9, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jul 30, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Sep 17, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Sep 18, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Oct 4, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Nov 27, 2024
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Jan 7, 2025
)" This reverts commit 24431ba.
pablogs9
added a commit
to micro-ROS/rcutils
that referenced
this pull request
Feb 3, 2025
)" This reverts commit 24431ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the commit explains the reasoning behind it.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.