Fixing up documentation build when using rosdoc2 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodall <[email protected]>
…sues Signed-off-by: William Woodall <[email protected]>
clalancette
approved these changes
Aug 5, 2021
aprotyas
approved these changes
Aug 5, 2021
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2021-9-16/22372/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main this this pull request does is eliminate a bunch of issues caused by files in
stdatomic_helpers. I spent a lot of time trying to squash the issues, but I think that, in the end, we won't run into these issues elsewhere and these files are implementation details really, so I've just excluded them completely from Doxygen.I also changed the
@fileto be\filein the headers, just to match the style throughout the rest of the package.In order to eliminate the rest of the warnings we have to resolve #333 and svenevs/exhale#111. As well as either resolve breathe-doc/breathe#722 or pin the version of
breatheback to a version without that warning.