Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to waitable.py #1328

Merged
merged 9 commits into from
Aug 21, 2024
Merged

Add types to waitable.py #1328

merged 9 commits into from
Aug 21, 2024

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
add types
761d8d5 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move typing into string
b5bac08 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move Future type into string
25a368c 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
flake8 fixes
09b9e9f 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
move typedicts to outside TYPE_CHECKING
2fbbd70 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
rerun stuck ci
127a7c8 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
undo accidental removal
a0ef489 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
add functions
b4fea94 
Signed-off-by: Michael Carlstrom <[email protected]>
@MichaelOrlov
Copy link

@sloretz Friendly ping for review this PR.

@sloretz
Copy link
Contributor

sloretz commented Aug 20, 2024

Pulls: #1328
Gist: https://gist.githubusercontent.com/sloretz/9bb0ffb130b7c59f7279e9e74392539f/raw/bd3a0e437388ae5a104e0c8608e30fe2d72483da/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14417

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented Aug 21, 2024

Rhel ros2cli tests failed with Fatal Python error: Segmentation fault. The same test is also failing in the nightly job: https://ci.ros2.org/view/nightly/job/nightly_linux-rhel_release/1994/testReport/ so CI LGTM.

Thank you for the PR!

@sloretz sloretz merged commit 7e3005a into ros2:rolling Aug 21, 2024
3 checks passed
@InvincibleRMC InvincibleRMC deleted the waitable.py-types branch September 13, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @MichaelOrlov @sloretz