Remove python_cmake_module use #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested review from
sloretz and
adityapande-1995
as code owners
fujitatomoya
approved these changes
Feb 15, 2024
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
ccb68ad to
94d9667
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
94d9667 to
386f05d
Compare
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
386f05d to
0aa5cd4
Compare
We really don't need it anymore, and can just use the builtin find_package(Python3). Signed-off-by: Chris Lalancette <[email protected]>
The comment in the commit explains the reasoning behind it. Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/remove-python-cmake-module
branch
from
0aa5cd4 to
3bd564f
Compare
|
CI for this (along with all of the rest of the changes needed) is in ros2/ros2#1524 (comment) |
fujitatomoya
added a commit
to fujitatomoya/rclpy
that referenced
this pull request
Oct 17, 2024
This reverts commit 1dd3b21. Signed-off-by: Tomoya.Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add in hints so that we find the unversioned python3 before finding versioned ones.
This must be merged before ros2/ros2#1524 ; see that pull request for more information about this change.