Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a Time and Duration Max static method #524

Closed
tfoote opened this issue Jul 25, 2018 · 0 comments
Closed

create a Time and Duration Max static method #524

tfoote opened this issue Jul 25, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tfoote
Copy link
Contributor

tfoote commented Jul 25, 2018

This will avoid requiring users to do things like this in algorithms and tests.

rclcpp::Duration(std::numeric_limits<int32_t>::max(),999999999)
@tfoote tfoote added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 25, 2018
@sagniknitr sagniknitr mentioned this issue Aug 20, 2018
Merged
@wjwwood wjwwood mentioned this issue Nov 13, 2020
Open
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@clalancette
Remove the maximum string size. (ros2#524)
cdf1b4d 
It wasn't preventing any allocations from happening, so it
doesn't seem to serve much purpose.  Also remove the tests
for the maximum string size.

Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoote @dirk-thomas