Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to check behavior when the queue size of the subscriber is reached #421

Open
dirk-thomas opened this issue Dec 5, 2017 · 4 comments
Open

add test to check behavior when the queue size of the subscriber is reached #421

dirk-thomas opened this issue Dec 5, 2017 · 4 comments
Labels
backlog enhancement New feature or request tests Failing or missing tests

Comments

@dirk-thomas
Copy link
Member

To cover the issue #280.
@dirk-thomas dirk-thomas added the enhancement New feature or request label Dec 5, 2017
@dirk-thomas dirk-thomas mentioned this issue Dec 5, 2017
Merged
@mikaelarguedas mikaelarguedas added the tests Failing or missing tests label Dec 5, 2017
@Karsten1987 Karsten1987 added this to the bouncy milestone Feb 26, 2018
@Karsten1987
Copy link
Contributor

@dirk-thomas I'll assign you to this ticket and given that the referencing issue is closed, I'll add this ticket to the bouncy milestone.
Feel free to re-assign or remove it from the milestone if you think so.

@dirk-thomas
Copy link
Member Author

Since I won't be working on this any time soon I will unassign myself. I also don't think having a test is critical for the next release either and will therefore also remove the milestone.

@dirk-thomas dirk-thomas removed their assignment Feb 26, 2018
@dirk-thomas dirk-thomas removed this from the bouncy milestone Feb 26, 2018
@Karsten1987 Karsten1987 added this to the untargeted milestone Feb 26, 2018
@Karsten1987
Copy link
Contributor

@dirk-thomas i added this ticket to untargeted milestone then.

@dirk-thomas
Copy link
Member Author

I don't think untargeted is a good choice either. That will imply that we will "never" take another look at this ticket. Adding test coverage for this seems to be a reasonable thing in the future though.

@dirk-thomas dirk-thomas removed this from the untargeted milestone Feb 26, 2018
nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@thomas-moulard @dirk-thomas
Fix argument passed to logging macros (ros2#421)
23510fe 
This commit fixes two problems with the logging
statements:
- %p requires a void * object to be passed
- %d expects an integer. For size_t objects, %zu should be used

Signed-off-by: Thomas Moulard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog enhancement New feature or request tests Failing or missing tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clalancette @dirk-thomas @Karsten1987 @mikaelarguedas