rclc_executor: improve enum type names

[JanStaschulat]

see issue #378

Thanks for your suggestion to improve the names of the enum type names @gavanderhoorn.

[JanStaschulat]

@Mergifyio backport iron humble

[mergify]

backport iron humble

✅ Backports have been created

• #382 rclc_executor: improve enum type names (backport #379) has been created for branch iron
• #383 rclc_executor: improve enum type names (backport #379) has been created for branch humble but encountered conflicts

[gavanderhoorn]

Thanks for addressing #378.

Tiny suggestion: I've seen other maintainers use a common prefix for enum members. This helps discoverability, especially when using an editor with code-completion (ie: start typing PREFIX_ and all values show up).

Using a prefix instead of an _EXECUTOR suffix would align with that practice, but it's completely up to you.

[pablogs9]

Just a comment, what about prefixing them with RCLC_*** ?

[codecov-commenter]

Codecov Report

Merging #379 (c3fddcc) into rolling (4b8670d) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           rolling     #379      +/-   ##
===========================================
- Coverage    69.63%   69.56%   -0.08%     
===========================================
  Files           16       16              
  Lines         2760     2760              
  Branches       766      766              
===========================================
- Hits          1922     1920       -2     
- Misses         452      453       +1     
- Partials       386      387       +1     

Impacted Files	Coverage Δ
rclc/src/rclc/executor.c	61.90% <66.66%> (ø)

... and 1 file with indirect coverage changes

[gavanderhoorn]

👍

[gavanderhoorn]

Thank you @JanStaschulat 👍