Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated rclc_examples (backport #332) #333

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2023

This is an automatic backport of pull request #332 done by Mergify.
Cherry-pick of e63b644 has failed:

On branch mergify/bp/foxy/pr-332
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit e63b644.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rclc_examples/CMakeLists.txt
	modified:   rclc_examples/src/example_executor.c
	renamed:    rclc_examples/src/example_executor_convenience.c -> rclc_examples/src/example_executor_only_rcl.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclc_examples/README.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit e63b644)

# Conflicts:
#	rclc_examples/README.md
@mergify mergify bot added the conflicts label Feb 7, 2023
@mergify mergify bot mentioned this pull request Feb 7, 2023
Signed-off-by: Jan Staschulat <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #333 (4a89861) into foxy (02472d6) will decrease coverage by 2.62%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             foxy     #333      +/-   ##
==========================================
- Coverage   62.93%   60.32%   -2.62%     
==========================================
  Files          13       14       +1     
  Lines        1419     1555     +136     
  Branches      416      507      +91     
==========================================
+ Hits          893      938      +45     
- Misses        337      339       +2     
- Partials      189      278      +89     
Impacted Files Coverage Δ
...c_parameter/test/rclc_parameter/test_parameter.cpp 33.08% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JanStaschulat JanStaschulat merged commit 23c65ba into foxy Feb 8, 2023
@JanStaschulat JanStaschulat deleted the mergify/bp/foxy/pr-332 branch February 8, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants