-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example real-time concurreny timer and subscription #329
Merged
JanStaschulat
merged 3 commits into
master
from
feature/example_short_timer_long_subscription
Feb 7, 2023
Merged
Example real-time concurreny timer and subscription #329
JanStaschulat
merged 3 commits into
master
from
feature/example_short_timer_long_subscription
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 69.20% 69.06% -0.15%
==========================================
Files 16 16
Lines 2715 2715
Branches 765 765
==========================================
- Hits 1879 1875 -4
- Misses 450 452 +2
- Partials 386 388 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pablogs9
approved these changes
Feb 7, 2023
@mergify backport humble foxy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
* initial example short timer long subscription duration Signed-off-by: Jan Staschulat <[email protected]> * added delay in subscription Signed-off-by: Jan Staschulat <[email protected]> * updated README Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit fd648d9)
mergify bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
* initial example short timer long subscription duration Signed-off-by: Jan Staschulat <[email protected]> * added delay in subscription Signed-off-by: Jan Staschulat <[email protected]> * updated README Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit fd648d9) # Conflicts: # rclc_examples/CMakeLists.txt
JanStaschulat
added a commit
that referenced
this pull request
Feb 7, 2023
* initial example short timer long subscription duration Signed-off-by: Jan Staschulat <[email protected]> * added delay in subscription Signed-off-by: Jan Staschulat <[email protected]> * updated README Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit fd648d9) Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat
added a commit
that referenced
this pull request
Feb 8, 2023
…331) * Example real-time concurreny timer and subscription (#329) * initial example short timer long subscription duration Signed-off-by: Jan Staschulat <[email protected]> * added delay in subscription Signed-off-by: Jan Staschulat <[email protected]> * updated README Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit fd648d9) # Conflicts: # rclc_examples/CMakeLists.txt * resolved merge conflict Signed-off-by: Jan Staschulat <[email protected]> --------- Signed-off-by: Jan Staschulat <[email protected]> Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in Slack https://micro-ros.slack.com/archives/CNC141G0N/p1675765402361599
The execution time of the subscription alternates (1ms, 900ms). It receives data every 1000ms. A slow timer with 100ms timeout is also defined. You can see from the results, that the timer events, while the subscription callback consumes 900ms, are lost and that there is no queue of timer events. That is, the there is no catch-up when there would be sufficient time when the subscription callback only needs 1ms.
Sample output: