Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter tests timeout #283

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Fix parameter tests timeout #283

merged 3 commits into from
Apr 13, 2022

Conversation

Acuadros95
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #283 (f30572a) into galactic (2442f75) will not change coverage.
The diff coverage is n/a.

❗ Current head f30572a differs from pull request most recent head 52b1126. Consider uploading reports for the commit 52b1126 to get more accurate results

@@            Coverage Diff            @@
##           galactic     #283   +/-   ##
=========================================
  Coverage     62.24%   62.24%           
=========================================
  Files            13       13           
  Lines          1523     1523           
  Branches        446      446           
=========================================
  Hits            948      948           
  Misses          367      367           
  Partials        208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2442f75...52b1126. Read the comment docs.

@Acuadros95 Acuadros95 requested a review from pablogs9 April 13, 2022 10:50
@Acuadros95
Copy link
Collaborator Author

@mergify backport foxy

@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

backport foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@Acuadros95 Acuadros95 requested a review from pablogs9 April 13, 2022 11:08
@pablogs9 pablogs9 merged commit 65b1164 into galactic Apr 13, 2022
@pablogs9 pablogs9 deleted the fix/parameters_timeout branch April 13, 2022 11:09
mergify bot pushed a commit that referenced this pull request Apr 13, 2022
@Acuadros95
Fix parameter tests timeout (#283)
13577e7 
* Add sleep on parameter event match

* Reset global values for gtest_repeat

* Fix var name

(cherry picked from commit 65b1164)
@mergify mergify bot mentioned this pull request Apr 13, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

backport foxy

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Apr 13, 2022
@mergify @Acuadros95
Fix parameter tests timeout (backport #283) (#284)
69e926b 
* Fix parameter tests timeout (#283)

* Add sleep on parameter event match

* Reset global values for gtest_repeat

* Fix var name

(cherry picked from commit 65b1164)

* Fix for foxy API

Co-authored-by: Antonio Cuadros <[email protected]>
Co-authored-by: acuadros95 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Acuadros95 @codecov-commenter @pablogs9