Fix action client & server deallocation #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 63.51% 63.52%
=======================================
Files 16 16
Lines 2149 2152 +3
Branches 641 641
=======================================
+ Hits 1365 1367 +2
- Misses 471 472 +1
Partials 313 313 ☔ View full report in Codecov by Sentry. |
|
Today's CI is passing, are we ok with that? @JanStaschulat @Acuadros95 can we assume that this is a CI or Action failure? |
Let's see if the scheduled CI job tomorrow builds successfully. |
|
Everything ok today: https://github.com/ros2/rclc/actions/runs/1932317583 |
JanStaschulat
approved these changes
Mar 4, 2022
|
LGTM |
Acuadros95
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the cleaning of deallocated sections