prepare bloom release 2.0.4-galactic #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Staschulat <[email protected]>
Codecov Report
@@ Coverage Diff @@
## galactic #193 +/- ##
=========================================
Coverage 60.68% 60.68%
=========================================
Files 13 13
Lines 1483 1483
Branches 444 444
=========================================
Hits 900 900
Misses 377 377
Partials 206 206 Continue to review full report at Codecov.
|
Acuadros95
pushed a commit
that referenced
this pull request
Nov 11, 2021
Signed-off-by: Jan Staschulat <[email protected]>
Acuadros95
pushed a commit
that referenced
this pull request
Nov 12, 2021
Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]>
pablogs9
added a commit
that referenced
this pull request
Nov 15, 2021
* ci workflow for galactic (#90) Signed-off-by: Jan Staschulat <[email protected]> * galactic: updated ci-job and codecov (#91) * bump version to 2.0.1 of galactic branch for new bloom release (#95) * Dummy (#100) * test of galactic bloom release see also #100 (#101) * Adds a context pointer to subscriptions (backport #107) (#120) * Adds a context pointer to subscriptions (#107) (cherry picked from commit 5b11c5a) # Conflicts: # rclc_examples/CMakeLists.txt * resolved merge confict Signed-off-by: Jan Staschulat <[email protected]> Co-authored-by: Brett Downing <[email protected]> Co-authored-by: Jan Staschulat <[email protected]> * version bump and updated changelog. (#139) Signed-off-by: Jan Staschulat <[email protected]> * prepare bloom release v2.0.3 for galactic (#159) Signed-off-by: Jan Staschulat <[email protected]> * refactor #116 remove callback_type (#154) (#163) * refactor #116 remove callback_type Signed-off-by: BrettRD <[email protected]> * rename subscription callback Signed-off-by: BrettRD <[email protected]> * deduplicate remove functions Signed-off-by: BrettRD <[email protected]> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <[email protected]> * updated rcl dependency to galactic (#184) Signed-off-by: Jan Staschulat <[email protected]> * added pingpong example (#172) (#188) * added pingpong example Signed-off-by: Jan Staschulat <[email protected]> * added two executor configuration to pingpong Signed-off-by: Jan Staschulat <[email protected]> * example_pingpong multiple files Signed-off-by: Jan Staschulat <[email protected]> * added class member function to executor Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit e0252bd) Co-authored-by: Jan Staschulat <[email protected]> * prepare bloom release 2.0.4-galactic (#193) Signed-off-by: Jan Staschulat <[email protected]> * Copy client to action client Initial mods to action client Initial executor support for action client Updates Fix Updates Copy client action to server action Initial action server changes Fix Revert "Copy client to action client" This reverts commit 304c70a. Initial Update Working state Uncrustify fix Update Update Add client Uncrustify Uncrus Apply suggestions from code review Co-authored-by: Ralph Lange <[email protected]> Initial test Fix data available logic Update tests Update Uncrust Revert "Update" This reverts commit 940aa96. Working state Working Building state Update Working state Working state Working state Uncrust Updates Fix cancelling reject Test approach modified Complete server tests Uncrusti Add multigoal test Fix Initial action client tests Add executor client cancel handlers Update action client Add cancel tests Tests update Uncrustify Refactor cancel response handling Update * Revert "Copy client to action client" This reverts commit d65adc7. * Initial version * Hide non public API * Fix abort API * Minor fix * Update * Fix * Add rclcpp dep * Update actions implementation * Delete COLCON_IGNORE * Fix dependencies export * cpplint * Initial Ralph changes Co-authored-by: Ralph Lange <[email protected]> * Add RCLC error * Refactor pop/take inner functions * Argument renaming * Argument renaming * Rename get API to find * Reafctor functio naming * Refactor naming * Remove explicit == true in conditionals * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <[email protected]> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <[email protected]> * Remove white lines * Update rclc/src/rclc/action_server.c * Apply suggestions from code review Co-authored-by: Jan Staschulat <[email protected]> * Apply suggestions from code review Co-authored-by: Jan Staschulat <[email protected]> * Add pointer check suggestions * Apply suggestions on executor * Add check for feedback msg on client * Put goal on default switch case * Revert code delete * Add comments to executor loops * Update loop comments * Apply for loop style where possible * Fix variable name * Fix rebase * ci workflow for galactic (#90) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * galactic: updated ci-job and codecov (#91) Signed-off-by: Antonio Cuadros <[email protected]> * bump version to 2.0.1 of galactic branch for new bloom release (#95) Signed-off-by: Antonio Cuadros <[email protected]> * Dummy (#100) Signed-off-by: Antonio Cuadros <[email protected]> * test of galactic bloom release see also #100 (#101) Signed-off-by: Antonio Cuadros <[email protected]> * Adds a context pointer to subscriptions (backport #107) (#120) * Adds a context pointer to subscriptions (#107) (cherry picked from commit 5b11c5a) # Conflicts: # rclc_examples/CMakeLists.txt * resolved merge confict Signed-off-by: Jan Staschulat <[email protected]> Co-authored-by: Brett Downing <[email protected]> Co-authored-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * version bump and updated changelog. (#139) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * prepare bloom release v2.0.3 for galactic (#159) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * refactor #116 remove callback_type (#154) (#163) * refactor #116 remove callback_type Signed-off-by: BrettRD <[email protected]> * rename subscription callback Signed-off-by: BrettRD <[email protected]> * deduplicate remove functions Signed-off-by: BrettRD <[email protected]> (cherry picked from commit 700ea24) Co-authored-by: Brett Downing <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * updated rcl dependency to galactic (#184) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * added pingpong example (#172) (#188) * added pingpong example Signed-off-by: Jan Staschulat <[email protected]> * added two executor configuration to pingpong Signed-off-by: Jan Staschulat <[email protected]> * example_pingpong multiple files Signed-off-by: Jan Staschulat <[email protected]> * added class member function to executor Signed-off-by: Jan Staschulat <[email protected]> (cherry picked from commit e0252bd) Co-authored-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * prepare bloom release 2.0.4-galactic (#193) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Copy client to action client Initial mods to action client Initial executor support for action client Updates Fix Updates Copy client action to server action Initial action server changes Fix Revert "Copy client to action client" This reverts commit 304c70a. Initial Update Working state Uncrustify fix Update Update Add client Uncrustify Uncrus Apply suggestions from code review Co-authored-by: Ralph Lange <[email protected]> Initial test Fix data available logic Update tests Update Uncrust Revert "Update" This reverts commit 940aa96. Working state Working Building state Update Working state Working state Working state Uncrust Updates Fix cancelling reject Test approach modified Complete server tests Uncrusti Add multigoal test Fix Initial action client tests Add executor client cancel handlers Update action client Add cancel tests Tests update Uncrustify Refactor cancel response handling Update Signed-off-by: Antonio Cuadros <[email protected]> * Revert "Copy client to action client" This reverts commit d65adc7. Signed-off-by: Antonio Cuadros <[email protected]> * Initial version Signed-off-by: Antonio Cuadros <[email protected]> * Hide non public API Signed-off-by: Antonio Cuadros <[email protected]> * Fix abort API Signed-off-by: Antonio Cuadros <[email protected]> * Minor fix Signed-off-by: Antonio Cuadros <[email protected]> * Update Signed-off-by: Antonio Cuadros <[email protected]> * Fix Signed-off-by: Antonio Cuadros <[email protected]> * Add rclcpp dep Signed-off-by: Antonio Cuadros <[email protected]> * Update actions implementation Signed-off-by: Antonio Cuadros <[email protected]> * Delete COLCON_IGNORE Signed-off-by: Antonio Cuadros <[email protected]> * Fix dependencies export Signed-off-by: Antonio Cuadros <[email protected]> * cpplint Signed-off-by: Antonio Cuadros <[email protected]> * Initial Ralph changes Co-authored-by: Ralph Lange <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Add RCLC error Signed-off-by: Antonio Cuadros <[email protected]> * Refactor pop/take inner functions Signed-off-by: Antonio Cuadros <[email protected]> * Argument renaming Signed-off-by: Antonio Cuadros <[email protected]> * Argument renaming Signed-off-by: Antonio Cuadros <[email protected]> * Rename get API to find Signed-off-by: Antonio Cuadros <[email protected]> * Reafctor functio naming Signed-off-by: Antonio Cuadros <[email protected]> * Refactor naming Signed-off-by: Antonio Cuadros <[email protected]> * Remove explicit == true in conditionals Signed-off-by: Antonio Cuadros <[email protected]> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Update rclc/src/rclc/executor.c Co-authored-by: Ralph Lange <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Remove white lines Signed-off-by: Antonio Cuadros <[email protected]> * Update rclc/src/rclc/action_server.c Signed-off-by: Antonio Cuadros <[email protected]> * Apply suggestions from code review Co-authored-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Apply suggestions from code review Co-authored-by: Jan Staschulat <[email protected]> Signed-off-by: Antonio Cuadros <[email protected]> * Add pointer check suggestions Signed-off-by: Antonio Cuadros <[email protected]> * Apply suggestions on executor Signed-off-by: Antonio Cuadros <[email protected]> * Add check for feedback msg on client Signed-off-by: Antonio Cuadros <[email protected]> * Put goal on default switch case Signed-off-by: Antonio Cuadros <[email protected]> * Revert code delete Signed-off-by: Antonio Cuadros <[email protected]> * Add comments to executor loops Signed-off-by: Antonio Cuadros <[email protected]> * Update loop comments Signed-off-by: Antonio Cuadros <[email protected]> * Apply for loop style where possible Signed-off-by: Antonio Cuadros <[email protected]> * Fix variable name Signed-off-by: Antonio Cuadros <[email protected]> * Fix rebase Signed-off-by: Antonio Cuadros <[email protected]> * Apply suggestions from code review Co-authored-by: Jan Staschulat <[email protected]> * removed unneccary reset of handle->data_available , in _rclc_check_for_new_data this flag is assigned again. Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]> * Change put goal function name Co-authored-by: Jan Staschulat <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Brett Downing <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]> Co-authored-by: Ralph Lange <[email protected]> Co-authored-by: Antonio Cuadros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tomorrow is a galactic sync
https://discourse.ros.org/t/preparing-for-galactic-sync-2021-08-24/21900