Feature request: check for valid ros context in spin_some #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: Jan Staschulat <[email protected]>
|
@mergify backport galactic foxy |
|
Command
Hey, I reacted but my real name is @Mergifyio |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 59.32% 60.03% +0.70%
==========================================
Files 13 13
Lines 1399 1236 -163
Branches 430 389 -41
==========================================
- Hits 830 742 -88
+ Misses 362 308 -54
+ Partials 207 186 -21
Continue to review full report at Codecov.
|
JanStaschulat
changed the title
JanStaschulat
changed the title
pablogs9
approved these changes
Jul 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit acf7f25)
mergify bot
pushed a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit acf7f25)
|
Command
|
JanStaschulat
added a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit acf7f25) Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat
added a commit
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit acf7f25) Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see micro-ROS#79 and #109
and some uncrustify reformatting.